feature: add plugin point before endpoint creating #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyb196
changed the title
setup priority of endpoint and decide whether enable libnetwork resolver to this endpoint and setup generic params of this endpoint. Signed-off-by: Frank Yang <yyb196@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
========================================
- Coverage 15.7% 15.5% -0.2%
========================================
Files 172 172
Lines 9620 9581 -39
========================================
- Hits 1511 1486 -25
+ Misses 8000 7991 -9
+ Partials 109 104 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Yang yyb196@gmail.com
Ⅰ. Describe what this PR did
which enables users to setup priority of endpoint and decide whether enable libnetwork resolver
to this endpoint and setup generic params of this endpoint.
Because one container may have multiple endpoints, users may want to keep the endpoint order whenever this container is started, this plugins enables users to do just that, priority more big the endpoint will be placed fronter.
Iptables may incurs performance issue, resolver in libnetwork use iptables to do its logic, some users want to disable it, and this plugin enable user to do it.
When creating a endpoint via remote plugin, users may want to pass more params to remote, this plugin enables users to specified generic params of the endpoint, which will be passed to the remote plugin by param
options.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
@rudyfly PTAL