Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add lxcfs binary check #1127

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Conversation

Letty5411
Copy link
Contributor

Signed-off-by: letty letty.ll@alibaba-inc.com

Ⅰ. Describe what this PR did

fix #606

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 13, 2018

Codecov Report

Merging #1127 into master will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   15.54%   15.79%   +0.25%     
==========================================
  Files         172      172              
  Lines        9739     9622     -117     
==========================================
+ Hits         1514     1520       +6     
+ Misses       8116     7992     -124     
- Partials      109      110       +1
Impacted Files Coverage Δ
client/client.go 33.33% <0%> (-3.04%) ⬇️
apis/server/container_bridge.go 0% <0%> (ø) ⬆️
daemon/mgr/cri.go 0% <0%> (ø) ⬆️
daemon/mgr/spec_blkio.go 0% <0%> (ø) ⬆️
daemon/mgr/container_types.go 15.38% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
cli/container.go 0% <0%> (ø) ⬆️
cli/common_flags.go 0% <0%> (ø) ⬆️
ctrd/snapshot.go 0% <0%> (ø) ⬆️
ctrd/image.go 0% <0%> (ø) ⬆️
... and 1 more

@Ace-Tang
Copy link
Contributor

Could you also add --enable-lxcfs flag in pouchd flag check, @Letty5411

@allencloud
Copy link
Collaborator

allencloud commented Apr 16, 2018

LGTM, please answer @Ace-Tang 's question.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 16, 2018
Signed-off-by: letty <letty.ll@alibaba-inc.com>
@Letty5411
Copy link
Contributor Author

@Ace-Tang add it, PTAL.

@Ace-Tang
Copy link
Contributor

Good, fix it will fail in my ubuntu.

@Ace-Tang Ace-Tang merged commit 9fff714 into AliyunContainerService:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] lxcfs related tests should check the lxcfs binary
5 participants