Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix daemon panic when meta snapshotter is nil #1140

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

oiooj
Copy link
Contributor

@oiooj oiooj commented Apr 17, 2018

fix #1139

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1140 into master will increase coverage by 0.85%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   14.75%   15.61%   +0.85%     
==========================================
  Files         172      172              
  Lines        9628     9688      +60     
==========================================
+ Hits         1421     1513      +92     
+ Misses       8102     8067      -35     
- Partials      105      108       +3
Impacted Files Coverage Δ
daemon/mgr/container.go 4.59% <0%> (-0.01%) ⬇️
pkg/utils/utils.go 78.15% <0%> (-1.85%) ⬇️
cli/command.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
client/client.go 46.66% <0%> (+10.3%) ⬆️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 17, 2018
@allencloud
Copy link
Collaborator

Thanks a lot for your contribution. This is exactly what we need. While we encourage that provide more details about the pull request description to illustrate what you did. @oiooj
Maybe next time, more info is better. Thanks again.

@allencloud allencloud merged commit 5f57ba3 into AliyunContainerService:master Apr 17, 2018
@oiooj oiooj deleted the pr-panic branch April 17, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project kind/panic LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] start daemon with cgroup path panic
6 participants