-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: parse volumes from image #1145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI fails:
|
rudyfly
force-pushed
the
volume
branch
2 times, most recently
from
April 17, 2018 11:46
b8765b9
to
804024e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
=========================================
- Coverage 16.03% 16% -0.04%
=========================================
Files 174 173 -1
Lines 9995 9967 -28
=========================================
- Hits 1603 1595 -8
+ Misses 8275 8255 -20
Partials 117 117
|
parse volumes from image, so pouchd will create a volume that is defined in image automatically. In addition, if volume has no size, the diskquota will set to volume. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
home-dir of pouch is configurable, how does |
@yyb196 |
LGTM, merge it |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
areas/storage
kind/feature
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
parse volumes from image, so pouchd will create a volume that is defined
in image automatically.
In addition, if volume has no size, the disk quota will set to volume.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
run a container with image what have volume
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com