Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix set quota-id without disk-quota #1157

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Apr 18, 2018

Ⅰ. Describe what this PR did

Setting quota-id without setting disk-quota, it should be failed and
returns error.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

# pouch run -d --quota-id -1 registry.hub.docker.com/library/busybox:latest
Error: failed to run container: {"message":"failed to set mount point disk quota: invalid argument, set quota-id without disk-quota"}

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 18, 2018
Setting quota-id without setting disk-quota, it should be failed and
returns error.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 18, 2018
@Letty5411 Letty5411 merged commit a81ff1b into AliyunContainerService:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants