bugfix: evaluate finish time of container in CRI correctly #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Apr 23, 2018
daemon/mgr/cri.go
Outdated
| if finishedAt != 0 { | ||
| finishTime, err := time.Parse(utils.TimeLayout, container.State.FinishedAt) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to parse container finish time: %v", err) |
There was a problem hiding this comment.
How about add the raw data in the error massage:
fmt.Errorf("failed to parse container finish time %s: %v", container.State.FinishedA, err)
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 15.96% 15.95% -0.01%
==========================================
Files 176 176
Lines 10135 10138 +3
==========================================
Hits 1618 1618
- Misses 8399 8402 +3
Partials 118 118
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
fixes problem mentioned in #1144
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews