Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove log format type check #1192

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

oiooj
Copy link
Contributor

@oiooj oiooj commented Apr 24, 2018

Option LogConfig is omitempty in config. That means we allow c.HostConfig.LogConfig is nil.

There is no need to check the log type, we don't use it now in log sub command, maybe in the furture.

Fix #1105
Fix #1072

Option `LogConfig` is omitempty in config.
That means we allow `c.HostConfig.LogConfig` is nil. There is no
need to check the log type, we don't use it now in log sub
command, maybe in the furture.
@pouchrobot
Copy link
Collaborator

@oiooj Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

ping @oiooj

CI fails according integration system.
Please refer to the CI failure Details button to corresponding test, and update your PR to pass CI.

If this is flaky test, welcome to track this with profiling an issue.

build url: https://travis-ci.org/alibaba/pouch/builds/370389143
build duration: 199s

@oiooj
Copy link
Contributor Author

oiooj commented Apr 24, 2018

The circleCI need to be fixed.

package golang.org/x/lint: unrecognized import path "golang.org/x/lint" (parse https://golang.org/x/lint?go-get=1: no go-import meta tags ())

@HusterWan
Copy link
Contributor

@oiooj The ci failed because golint download error, we will build a base image contains golint tool, in case network problem.

thanks a lot for your work !!!

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 24, 2018
@HusterWan HusterWan merged commit 24541df into AliyunContainerService:master Apr 24, 2018
@oiooj oiooj deleted the pr-log-panic branch April 24, 2018 03:08
This was referenced Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/log LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants