bugfix: remove update image and fix bugs when update env #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
+ Coverage 15.57% 15.61% +0.04%
==========================================
Files 178 178
Lines 10454 10427 -27
==========================================
Hits 1628 1628
+ Misses 8706 8679 -27
Partials 120 120
|
allencloud
reviewed
Apr 24, 2018
daemon/mgr/container.go
Outdated
| c.meta.Config.Image = ref | ||
| c.meta.Image = ref | ||
| if c.IsRunning() && len(config.Env) > 0 { | ||
| return fmt.Errorf("Only can update the container's Env when it stopped") | ||
| } | ||
|
|
||
| if len(config.Env) != 0 { |
There was a problem hiding this comment.
I think we could remove this line of code, since the for loop below could handle the situation of config.Env has a length of 0.
HusterWan
force-pushed
the
zr/fix-update
branch
from
e57ef60 to
ae47c9b
Compare
allencloud
reviewed
Apr 25, 2018
| } | ||
|
|
||
| command.PouchRun("rm", "-f", name).Assert(c, icmd.Success) | ||
| } |
There was a problem hiding this comment.
Could you add an integration test to verify updating env for a running container? @HusterWan
HusterWan
force-pushed
the
zr/fix-update
branch
from
ae47c9b to
2eaac7a
Compare
Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/fix-update
branch
from
2eaac7a to
1060518
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1188
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews