Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: make markdownlint in Dockerfile #1204

Merged

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

We wish to add all repo needed software in Dockerfile, so we could use a single to image to integration test, circleci testing and no dependency with outer link.

We need to add all the following software:

With this pull request passed and merged, we need to update file https://github.com/alibaba/pouch/blob/master/.circleci/config.yml to use a single one image.

My plan is to build this Dockerfile to be allencloud/pouch:base20180426.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@HusterWan
Copy link
Contributor

awsome work!!!

@codecov-io
Copy link

Codecov Report

Merging #1204 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1204     +/-   ##
=========================================
+ Coverage   15.85%   15.96%   +0.1%     
=========================================
  Files         177      176      -1     
  Lines       10266    10135    -131     
=========================================
- Hits         1628     1618     -10     
+ Misses       8518     8399    -119     
+ Partials      120      118      -2
Impacted Files Coverage Δ
daemon/mgr/container_types.go 15.38% <0%> (-9.94%) ⬇️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
daemon/mgr/cri.go 0% <0%> (ø) ⬆️
daemon/containerio/options.go 0% <0%> (ø) ⬆️
ctrd/container.go 0% <0%> (ø) ⬆️
daemon/containerio/container_io.go 0% <0%> (ø) ⬆️
cli/logs.go 0% <0%> (ø) ⬆️
daemon/containerio/cio.go
apis/opts/mountpoint.go 84.61% <0%> (+6.04%) ⬆️

@allencloud
Copy link
Collaborator Author

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@allencloud allencloud merged commit e4a33e2 into AliyunContainerService:master Apr 25, 2018
@allencloud allencloud deleted the update-Dockerfile branch April 25, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants