Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make restart can restart stopped container #1208

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

Make pouch be able to restart a stopped container.

Ⅱ. Does this pull request fix one issue?

fixes #1206

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Apr 25, 2018
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@codecov-io
Copy link

Codecov Report

Merging #1208 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   15.59%   15.59%           
=======================================
  Files         178      178           
  Lines       10441    10441           
=======================================
  Hits         1628     1628           
  Misses       8693     8693           
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/container.go 0% <0%> (ø) ⬆️

@yyb196
Copy link
Collaborator

yyb196 commented Apr 25, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@yyb196 yyb196 merged commit a7391eb into AliyunContainerService:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] restart shouldn't complaint about cannot restart a non running container
4 participants