Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add parse Config.Volumes when create container #1219

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Apr 26, 2018

Ⅰ. Describe what this PR did

Add parse Config.Volumes when create container.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

Add parse Config.Volumes when create container.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@pouchrobot pouchrobot added areas/storage kind/bug This is bug report for project size/XL labels Apr 26, 2018
@rudyfly rudyfly requested a review from HusterWan April 26, 2018 05:29
@codecov-io
Copy link

Codecov Report

Merging #1219 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   15.68%   15.62%   -0.07%     
==========================================
  Files         171      171              
  Lines       10408    10452      +44     
==========================================
  Hits         1633     1633              
- Misses       8655     8699      +44     
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/container.go 0% <0%> (ø) ⬆️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 26, 2018
@HusterWan HusterWan merged commit 2868c9f into AliyunContainerService:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants