bugfix: setRawMode can only be set when the user set tty

[fuweid]

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

setRawMode is used to terminal case. If the shell is non-interactive or non-terminal, we should not set the raw mode for the input.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how you did it

check tty before set the raw mode

Ⅳ. Describe how to verify it

we need to set the shell in no-interactive mode, please use the following the script:

#!/bin/bash

cat >test <<'EOF'
set +i # set non-interactive
pouch run -i busybox:latest echo test
EOF

echo 'running bash -i <test'
bash -i <test

before this change:

➜  /tmp sh ./test-interactive
running bash -i <test
root@ubuntu-xenial:/tmp# set +i # set non-interactive
root@ubuntu-xenial:/tmp# pouch run -i busybox:latest echo test
Error: failed to set raw mode
root@ubuntu-xenial:/tmp# exit

after this change:

➜  /tmp sh ./test-interactive
running bash -i <test
root@ubuntu-xenial:/tmp# set +i # set non-interactive
root@ubuntu-xenial:/tmp# pouch run -i busybox:latest echo test
test
root@ubuntu-xenial:/tmp# exit

Ⅴ. Special notes for reviews

[codecov-io]

Codecov Report

Merging #1233 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   15.36%   15.36%   -0.01%     
==========================================
  Files         172      172              
  Lines       10629    10630       +1     
==========================================
  Hits         1633     1633              
- Misses       8876     8877       +1     
  Partials      120      120

Impacted Files	Coverage Δ
cli/run.go	0% <0%> (ø)	⬆️

[HusterWan]

LGTM