-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deploy kubernetes with pouch powerd by aliyun #1236
docs: deploy kubernetes with pouch powerd by aliyun #1236
Conversation
PouchContainer is a open source project globally. Domestic is not proper word to classify Chinese users and other country's user. Please try to find some reasonable way to describe the doc. Thanks alot. @starnop |
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
+ Coverage 15.27% 15.36% +0.08%
==========================================
Files 172 172
Lines 10691 10630 -61
==========================================
Hits 1633 1633
+ Misses 8938 8877 -61
Partials 120 120
|
"In China" ,that might be a little better. is it ok? @allencloud |
|
||
NOTE: It will be failed to deploy with recent released Kubernetes 1.10.0. Because Kubernetes 1.10.0 has updated CRI from v1alpha1 to v1alpha2 which Pouch has not supported yet. We will try to full support CRI v1alpha1 first and then v1alpha2. | ||
|
||
Pouch: Version 0.3.0 is recommanded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now Pouch v0.4.0 has been released, it is recommended.
recommanded -> recommended ?
@@ -17,7 +17,7 @@ Updated: 2018.3.30 | |||
|
|||
## Overview | |||
|
|||
This document shows how to easily install a Kubernetes cluster with Pouch as the container runtime. | |||
This document shows how to easily install a Kubernetes cluster with Pouch as the container runtime.If it's not convenience for you,there is an easy guide for you to quickly experience this amazing combination in China [Kubernetes + Pouch + Domestic](pouch_with_kubernetes_deploying_domestic.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...., in China.... it's wired...
You know China is an open country :)
It might be better to say:
For Chinese customer, it's might be faster and easier to download Kubernetes components and various kinds of container images from Aliyun ....
@@ -0,0 +1,267 @@ | |||
# Deploy Kubernetes With Pouch In China |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy Kubernetes With Pouch, powered by Aliyun?
@allencloud WDYT? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the way you provided is quite reasonable. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about “Deploy Kubernetes With Pouch using Aliyun Image Repository.”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we also download kubernetes components from Aliyun.
I thinks mine is better , hhh...
98020b2
to
188b54d
Compare
@starnop Thanks for your contribution. 🍻 |
LGTM |
Ⅰ. Describe what this PR did
deploy kubernetes with pouch powerd by aliyun
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews