Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix mountpoint binary not found error #1253

Merged

Conversation

shaloulcy
Copy link
Contributor

In some linux releases, the mountpoint is not under /usr/bin dir, which
causes the failure of tmpfs detachment. So we only use the mountpoint,
which is in the system path

Signed-off-by: Eric Li lcy041536@gmail.com

Ⅰ. Describe what this PR did

In some linux releases, the mountpoint is not under /usr/bin dir, which
causes the failure of tmpfs detachment. So we only use the mountpoint,
which is in the system path

Ⅱ. Does this pull request fix one issue?

fixes #1252

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

In some linux releases, the mountpoint is not under /usr/bin dir, which
causes the failure of tmpfs detachment. So we only use the mountpoint,
which is in the system path

Signed-off-by: Eric Li <lcy041536@gmail.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #1253 into master will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
+ Coverage   15.27%   15.36%   +0.08%     
==========================================
  Files         172      172              
  Lines       10691    10629      -62     
==========================================
  Hits         1633     1633              
+ Misses       8938     8876      -62     
  Partials      120      120
Impacted Files Coverage Δ
pkg/utils/mount.go 0% <0%> (ø) ⬆️
daemon/mgr/network.go 3.47% <0%> (-0.01%) ⬇️
cli/update.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
cli/run.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
daemon/config/config.go 10% <0%> (+2.1%) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented May 2, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 2, 2018
@rudyfly rudyfly merged commit 1680377 into AliyunContainerService:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] /usr/bin/mountpoint binary not found
4 participants