-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the output file is used incorrectly & fix the wrong test case name #1258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 15.26% 15.26%
=======================================
Files 172 172
Lines 10698 10698
=======================================
Hits 1633 1633
Misses 8945 8945
Partials 120 120
|
Hi @xieyanke , thank you for your contribution. The change is good. But before we merge your change, you squash your multiple commits into one commit and use Thanks a lot. |
@xieyanke thanks for your PR, here is some advice for create a PR, hope to help you:
If you need any help, please contact us for anytime!!! |
test: fix the wrong test case name.
@xieyanke Thanks for your contribution. 🍻 |
I have squashed multi commits into one commit @HusterWan Thank you for your advice. |
LGTM |
Ⅰ. Describe what this PR did
fix the wrong test case name
fix the output file is used incorrectly