Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the output file is used incorrectly & fix the wrong test case name #1258

Merged
merged 1 commit into from
May 2, 2018

Conversation

xieyanke
Copy link
Contributor

@xieyanke xieyanke commented May 1, 2018

Ⅰ. Describe what this PR did

fix the wrong test case name
fix the output file is used incorrectly

@CLAassistant
Copy link

CLAassistant commented May 1, 2018

CLA assistant check
All committers have signed the CLA.

@xieyanke xieyanke changed the title fix the wrong test case name test: fix the wrong test case name May 1, 2018
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #1258 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   15.26%   15.26%           
=======================================
  Files         172      172           
  Lines       10698    10698           
=======================================
  Hits         1633     1633           
  Misses       8945     8945           
  Partials      120      120
Impacted Files Coverage Δ
pkg/exec/exec.go 0% <0%> (ø) ⬆️

@xieyanke xieyanke changed the title test: fix the wrong test case name test: fix the wrong test case name and May 1, 2018
@xieyanke xieyanke changed the title test: fix the wrong test case name and test: fix the wrong test case name May 1, 2018
@xieyanke xieyanke changed the title test: fix the wrong test case name bugfix: fix the output file is used incorrectly & fix the wrong test case name May 1, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label May 1, 2018
@fuweid
Copy link
Contributor

fuweid commented May 2, 2018

Hi @xieyanke , thank you for your contribution.

The change is good. But before we merge your change, you squash your multiple commits into one commit and use git commit -s to sign it. More information is here https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md#commit-rules

Thanks a lot.

@fuweid fuweid self-requested a review May 2, 2018 01:23
@HusterWan
Copy link
Contributor

HusterWan commented May 2, 2018

@xieyanke thanks for your PR, here is some advice for create a PR, hope to help you:

  1. fresh your local code:
git fetch upstream

git rebase upstream/master 
  1. squash your commit:
git rebase -i xxx

If you need any help, please contact us for anytime!!!

test: fix the wrong test case name.
@pouchrobot
Copy link
Collaborator

@xieyanke Thanks for your contribution. 🍻
Please sign off in each of your commits.

@xieyanke
Copy link
Contributor Author

xieyanke commented May 2, 2018

I have squashed multi commits into one commit

@HusterWan Thank you for your advice.

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 2, 2018
@HusterWan HusterWan merged commit 3d2c538 into AliyunContainerService:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants