Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: set container env failed Invalid cross-device link #1260

Merged

Conversation

HusterWan
Copy link
Contributor

@HusterWan HusterWan commented May 2, 2018

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

Update env of running container failed: Invalid cross-device link, caused by not set overlayfs work diskquota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

wrong container's disk quota:

[root@e19h16400.et15sqa /home/ziren.wzr]
#lsattr -p /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/170
    0 --------------e---- /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/170/work
16777514 --------------e---P /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/170/fs

normal container's disk quota, workdir disk quota is 0:

[root@e19h16400.et15sqa /home/ziren.wzr]
#lsattr -p /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/171
16777514 --------------e---P /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/171/work
16777514 --------------e---P /home/t4/pouch/containerd/root/io.containerd.snapshotter.v1.overlayfs/snapshots/171/fs

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels May 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #1260 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   15.26%   15.26%   -0.01%     
==========================================
  Files         172      172              
  Lines       10698    10699       +1     
==========================================
  Hits         1633     1633              
- Misses       8945     8946       +1     
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/spec_hook.go 0% <0%> (ø) ⬆️

@yyb196
Copy link
Collaborator

yyb196 commented May 2, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 2, 2018
@yyb196 yyb196 merged commit d3e9ccc into AliyunContainerService:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants