-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update lock policy for container management #1307
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
allencloud:modify-lock
Jun 5, 2018
Merged
feature: update lock policy for container management #1307
allencloud
merged 1 commit into
AliyunContainerService:master
from
allencloud:modify-lock
Jun 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
changed the title
feature: update lock policy for container management
[WIP] feature: update lock policy for container management
May 11, 2018
allencloud
force-pushed
the
modify-lock
branch
15 times, most recently
from
May 14, 2018 07:21
536d62b
to
a8596a8
Compare
This pull request still do no lock on |
allencloud
changed the title
[WIP] feature: update lock policy for container management
feature: update lock policy for container management
May 15, 2018
allencloud
force-pushed
the
modify-lock
branch
3 times, most recently
from
June 4, 2018 02:13
d603ed6
to
cb4a002
Compare
Thanks godness, this pr has passed all the ci tests. While to avoid if this is coincidence, I re-trigger the test to do a double check. |
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/feature
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
In the container manager, code usually use
to avoid race condition. While I think it is not so preferred since it does have serious affect on performance.
This PR dis three types of things:
Ⅱ. Does this pull request fix one issue?
fixes #1244
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews