bugfix: make the daemon exit happy #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the daemon server fails, the process will be hang because the no-one closes the channel. We should exit. Signed-off-by: Wei Fu <fhfuwei@163.com>
fuweid
requested review from
allencloud,
HusterWan,
rudyfly and
shaloulcy
and removed request for
allencloud and
HusterWan
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
=======================================
Coverage 16.42% 16.42%
=======================================
Files 183 183
Lines 11309 11309
=======================================
Hits 1857 1857
Misses 9316 9316
Partials 136 136 |
HusterWan
reviewed
May 14, 2018
|
|
||
| os.Exit(1) | ||
| case err := <-errCh: | ||
| // FIXME: should we do the cleanup like signal handle? |
There was a problem hiding this comment.
I think we also should do cleanup when daemon exited.
I do not know if this case will happen: pouchd panic and return error, then we should make the daemon exit gracefully. WDYT ?
There was a problem hiding this comment.
Agree. But for now, we should hold the scope like @rudyfly said. Refactor the code in the following PR. WDYT?
There was a problem hiding this comment.
Confirm with @HusterWan , let us add TODO here.
|
LGTM, and add TODO when server cause error, what to do cleanup. |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the daemon server fails, the process will be hang because the
no-one closes the channel. We should exit.
Signed-off-by: Wei Fu fhfuwei@163.com
Ⅰ. Describe what this PR did
Make the daemon exit happy.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Basically, we should run the daemon main in new goroutine and wait for it to exit. Based on this, we can receive the signal and clean it up.
Ⅳ. Describe how to verify it
Use available port and it should be success.
Use used port and it should be fail
Ⅴ. Special notes for reviews
@allencloud , @HusterWan and @rudyfly
Should we need to clean it up like
sigHandlewhen we receive error fromRun()?cc @shaloulcy