Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: using existing image and fix shell format error #1313

Merged
merged 1 commit into from
May 14, 2018

Conversation

Letty5411
Copy link
Contributor

@Letty5411 Letty5411 commented May 14, 2018

Signed-off-by: letty letty.ll@alibaba-inc.com

Ⅰ. Describe what this PR did

Push a test image to docker registry and pull it in each test instead of build a fresh new image.
In this way, it may reduce the test cost time.
Also fix some shell format by handy.

Ⅱ. Does this pull request fix one issue?

fix #1282

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: letty <letty.ll@alibaba-inc.com>
@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/L labels May 14, 2018
@fuweid
Copy link
Contributor

fuweid commented May 14, 2018

LGTM

@Letty5411 Letty5411 merged commit 08fb19a into AliyunContainerService:master May 14, 2018
@Letty5411 Letty5411 deleted the 0513 branch May 14, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhance] skip docker build in hack/make.sh
3 participants