Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: format topExamples code and add execExample. #1319

Merged
merged 1 commit into from
May 15, 2018
Merged

refactor: format topExamples code and add execExample. #1319

merged 1 commit into from
May 15, 2018

Conversation

soarpenguin
Copy link
Contributor

Ⅰ. Describe what this PR did

refactor: format topExamples code and add execExample.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@soarpenguin Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @soarpenguin
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your work. I will merge this until the readiness of CI. 🥂

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 15, 2018
@codecov-io
Copy link

Codecov Report

Merging #1319 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
- Coverage   17.39%   17.39%   -0.01%     
==========================================
  Files         189      189              
  Lines       11772    11776       +4     
==========================================
  Hits         2048     2048              
- Misses       9576     9580       +4     
  Partials      148      148
Impacted Files Coverage Δ
cli/top.go 0% <0%> (ø) ⬆️
cli/exec.go 0% <0%> (ø) ⬆️
cri/src/cri_utils.go
cri/src/cri_network.go
cri/src/cri.go
cri/src/cri_types.go
cri/src/cri_wrapper.go
cri/src/cri_stream.go
daemon/mgr/cri.go 0% <0%> (ø)
daemon/mgr/cri_network.go 0% <0%> (ø)
... and 4 more

@allencloud allencloud merged commit 22a0327 into AliyunContainerService:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants