bugfix: markStopped may failed, will cause container status not right #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Wan <zirenwan@gmail.com>
|
LGTM |
pouchrobot
added
the
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
- Coverage 17.36% 17.35% -0.01%
==========================================
Files 189 189
Lines 11793 11799 +6
==========================================
Hits 2048 2048
- Misses 9597 9603 +6
Partials 148 148
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
markStoppedAndReleasedo three things now:stopped2and3may failed, it will make container status not changed, so we should ensure container status can be synced as soon as possibleⅡ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews