Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allow use image by digest id #1351

Merged
merged 1 commit into from
May 18, 2018
Merged

feature: allow use image by digest id #1351

merged 1 commit into from
May 18, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented May 18, 2018

Basically, the user can use sha256:xyz to inspect image or run
container.

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

Enhance the Image Manager: Allow user to use image digest-type ID to consume pouch image.

For example, we pull busybox:1.28 by pouch. After pulled, the use can use the following method to inspect the image:

  • pouch image inspect 8ac48589692a
  • pouch image inspect sha256:8ac48589692a
  • pouch image inspect busybox:1.28
  • pouch image inspect busybox@sha256:58ac43b2cc92c687a32c8be6278e50a063579655fe3090125dcb2af0ff9e1a64

Ⅱ. Does this pull request fix one issue?

Fixes #1348

Ⅲ. Describe how you did it

Update the imageStore search functionality. We add the `sha256:" If the refOrID miss.

BTW, both the Delete and Search functionality should use the following method to check the reference is ID or not.

reference.IsNamedOnly(ref) || strings.HasPrefix(id, ref)

Ⅳ. Describe how to verify it

One of case is Use the Digest ID to run container

➜  pouch run -it sha256:8ac48589692a53a9b8c2d1ceaa6b402665aa7fe667ba51ccc03002300856d8c7 ls
bin   dev   etc   home  proc  root  run   sys   tmp   usr   var

Ⅴ. Special notes for reviews

feature: allow use image by digest id
8e862f9 
Basically, the user can use sha256:xyz to inspect image or run
container.

Signed-off-by: Wei Fu <fhfuwei@163.com>
@fuweid fuweid requested review from allencloud and YaoZengzeng May 18, 2018 06:02
@codecov-io
Copy link

Codecov Report

Merging #1351 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   17.32%   17.34%   +0.02%     
==========================================
  Files         189      189              
  Lines       11823    11828       +5     
==========================================
+ Hits         2048     2052       +4     
- Misses       9627     9628       +1     
  Partials      148      148
Impacted Files Coverage Δ
cri/src/cri.go 0% <0%> (ø) ⬆️
daemon/mgr/image.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
daemon/mgr/image_store.go 81.35% <100%> (+0.65%) ⬆️
daemon/mgr/volume.go 0% <0%> (ø) ⬆️

@YaoZengzeng
Copy link
Contributor

I've figured out the logic of the code and test it on my local machine, it works fine.

LGTM

@YaoZengzeng YaoZengzeng merged commit acbd19a into AliyunContainerService:master May 18, 2018
starnop added a commit to starnop/pouch that referenced this pull request May 20, 2018
@starnop
Squashed commit of the following:
6c6650d 
commit 75aab2b
Merge: 5c8993b 2f2e9c1
Author: Starnop <starnop@163.com>
Date:   Sat May 19 21:51:30 2018 +0800

    Merge branch 'cri-compatibility' of github.com:Starnop/pouch into cri-compatibility

commit 2f2e9c1
Merge: bd9c4fd acbd19a
Author: Starnop <starnop@163.com>
Date:   Fri May 18 15:32:31 2018 +0800

    Merge branch 'master' of https://github.com/alibaba/pouch into cri-compatibility

commit acbd19a
Merge: 6cef601 8e862f9
Author: Yao Zengzeng <yaozengzeng@zju.edu.cn>
Date:   Fri May 18 15:27:01 2018 +0800

    Merge pull request AliyunContainerService#1351 from fuweid/feature_allow_use_image_by_digest_id

    feature: allow use image by digest id

commit 6cef601
Merge: 4423313 caf45ec
Author: Wei Fu <fhfuwei@163.com>
Date:   Fri May 18 15:10:30 2018 +0800

    Merge pull request AliyunContainerService#1350 from Ace-Tang/version

    build: generate version information at build time

commit caf45ec
Author: Ace-Tang <aceapril@126.com>
Date:   Fri May 18 13:31:25 2018 +0800

    build: generate version information at build time

    auto-generate git commit, build time at build time,
    fix go-version hard code.

    Signed-off-by: Ace-Tang <aceapril@126.com>

commit 8e862f9
Author: Wei Fu <fhfuwei@163.com>
Date:   Fri May 18 13:50:42 2018 +0800

    feature: allow use image by digest id

    Basically, the user can use sha256:xyz to inspect image or run
    container.

    Signed-off-by: Wei Fu <fhfuwei@163.com>

commit 4423313
Merge: 8410064 f67cf08
Author: Allen Sun <shlallen1990@gmail.com>
Date:   Fri May 18 11:44:39 2018 +0800

    Merge pull request AliyunContainerService#1326 from shaloulcy/core_volume

    feature: remote volume driver

commit 8410064
Merge: 8af60a9 852d4f4
Author: Wei Fu <fhfuwei@163.com>
Date:   Fri May 18 10:39:15 2018 +0800

    Merge pull request AliyunContainerService#1339 from rhinoceros/master

    docs: Update INSTALLATION.md apt-key fingerprint BE2F475F

commit f67cf08
Author: Eric Li <lcy041536@gmail.com>
Date:   Mon May 14 12:19:46 2018 +0800

    feature: remote volume driver

    Signed-off-by: Eric Li <lcy041536@gmail.com>

commit bd9c4fd
Merge: 8d01e30 521ca7c
Author: Starnop <starnop@163.com>
Date:   Thu May 17 11:11:40 2018 +0800

    Merge branch 'master' of https://github.com/alibaba/pouch into cri-compatibility

commit 8af60a9
Merge: ecbe3b6 13a17b5
Author: Allen Sun <shlallen1990@gmail.com>
Date:   Fri May 18 09:43:40 2018 +0800

    Merge pull request AliyunContainerService#1349 from pouchrobot/auto-doc-2018-05-18

    docs: auto generate pouch cli/api docs via code

commit 13a17b5
Author: pouchrobot <pouch-dev@list.alibaba-inc.com>
Date:   Fri May 18 01:28:51 2018 +0000

    docs: auto generate pouch cli docs via code

    Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

commit 5c8993b
Merge: 8d01e30 521ca7c
Author: Starnop <starnop@163.com>
Date:   Thu May 17 11:11:40 2018 +0800

    Merge branch 'master' of https://github.com/alibaba/pouch into cri-compatibility

commit ecbe3b6
Merge: 3374daf 7fc11df
Author: Wei Fu <fhfuwei@163.com>
Date:   Thu May 17 18:53:20 2018 +0800

    Merge pull request AliyunContainerService#1227 from Ace-Tang/full_spec_params

    feature: add pidslimit implement

commit 7fc11df
Author: Ace-Tang <aceapril@126.com>
Date:   Fri May 11 16:25:32 2018 +0800

    feature: add pidslimit implement

    Signed-off-by: Ace-Tang <aceapril@126.com>

commit 3374daf
Merge: 89a5ae5 fd8e0f7
Author: Allen Sun <shlallen1990@gmail.com>
Date:   Thu May 17 13:44:52 2018 +0800

    Merge pull request AliyunContainerService#1341 from Letty5411/0517-assertfix

    test: enhance cli related tests

commit 89a5ae5
Merge: 521ca7c 8469cea
Author: Wei Fu <fhfuwei@163.com>
Date:   Thu May 17 13:17:47 2018 +0800

    Merge pull request AliyunContainerService#1331 from Letty5411/0516-doc

    doc: update test.md about how to run test

commit fd8e0f7
Author: letty <letty.ll@alibaba-inc.com>
Date:   Thu May 17 11:23:16 2018 +0800

    test: enhance test

    Signed-off-by: letty <letty.ll@alibaba-inc.com>

commit 521ca7c
Merge: 19c956b 6b2a8b4
Author: Yao Zengzeng <yaozengzeng@zju.edu.cn>
Date:   Thu May 17 10:39:06 2018 +0800

    Merge pull request AliyunContainerService#1340 from ZouRui89/race_off

    bugfix: move IO part behind to ensure execConfig result assignment before IO closes

commit 6b2a8b4
Author: Zou Rui <21751189@zju.edu.cn>
Date:   Wed May 16 18:03:27 2018 +0800

    bugfix: move IO part behind to ensure execConfig result assignment before IO closes

    Signed-off-by: Zou Rui <21751189@zju.edu.cn>

commit 8d01e30
Merge: 9339a70 19c956b
Author: Starnop <starnop@163.com>
Date:   Wed May 16 12:57:14 2018 +0800

    Merge branch 'master' of https://github.com/alibaba/pouch into cri-compatibility

commit 852d4f4
Author: rhinoceros.xn <rhinoceros.xn@gmail.com>
Date:   Wed May 16 17:37:51 2018 +0800

    Update INSTALLATION.md

    $ apt-key fingerprint BE2F475F
    pub   4096R/BE2F475F 2018-02-28
          Key fingerprint = F443 EDD0 4A58 7E8B F645  9C40 CF68 F84A BE2F 475F
    uid                  opsx-admin <opsx@service.alibaba.com>

commit 8469cea
Author: letty <letty.ll@alibaba-inc.com>
Date:   Wed May 16 10:08:32 2018 +0800

    doc: update test.md about how to run test

    Signed-off-by: letty <letty.ll@alibaba-inc.com>

commit 9339a70
Author: Starnop <starnop@163.com>
Date:   Tue May 15 17:35:53 2018 +0800

    cri com and up
@pouchrobot pouchrobot mentioned this pull request May 24, 2018
Closed
@fuweid fuweid deleted the feature_allow_use_image_by_digest_id branch August 3, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allencloud allencloud Awaiting requested review from allencloud

@YaoZengzeng YaoZengzeng Awaiting requested review from YaoZengzeng

Assignees
No one assigned
Labels
kind/feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] create container using image ID with digest algorithm prefix
4 participants
@fuweid @codecov-io @YaoZengzeng @pouchrobot