Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add volume drivers info for system info #1352

Merged

Conversation

shaloulcy
Copy link
Contributor

feature: add volume drivers info for system info

Signed-off-by: Eric Li lcy041536@gmail.com

Ⅰ. Describe what this PR did

add volume drivers info when return system info

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

~# pouch info
Containers: 17
 Running: 2
 Paused: 0
 Stopped: 15
Images:  4
ID: 
Name: ubuntu-1
Server Version: 0.4.0
Storage Driver: overlayfs
Driver Status: []
Logging Driver: 
Volume Drivers: [local-persist ceph tmpfs local]
Cgroup Driver: 
runc: <nil>
containerd: <nil>
Security Options: []
Kernel Version: 4.4.0-116-generic
Operating System: "Ubuntu 16.04.4 LTS"
OSType: linux
Architecture: amd64
HTTP Proxy: 
HTTPS Proxy: 
Registry: https://index.docker.io/v1/
Experimental: false
Debug: true
Labels:
  node_ip=127.0.1.1
  SN=0
CPUs: 1
Total Memory: 3.859 GiB
Pouch Root Dir: /var/lib/pouch
LiveRestoreEnabled: true
LxcfsEnabled: false
Daemon Listen Addresses: [unix:///var/run/pouchd.sock]

Ⅴ. Special notes for reviews

@rudyfly
Copy link
Collaborator

rudyfly commented May 18, 2018

Could you add cli test for pouch info?

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #1352 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   17.34%   17.31%   -0.03%     
==========================================
  Files         189      189              
  Lines       11829    11826       -3     
==========================================
- Hits         2052     2048       -4     
- Misses       9630     9631       +1     
  Partials      147      147
Impacted Files Coverage Δ
cli/info.go 0% <0%> (ø) ⬆️
daemon/mgr/system.go 0% <0%> (ø) ⬆️
daemon/mgr/image_store.go 80.7% <0%> (-0.66%) ⬇️
cri/src/cri.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
daemon/mgr/image.go 0% <0%> (ø) ⬆️

@shaloulcy
Copy link
Contributor Author

@rudyfly pouch info has too many informations related pouchd daemon and host. So it's not easy for ci test

@allencloud
Copy link
Collaborator

pouch info has too many informations related pouchd daemon and host. So it's not easy for ci test

You could this part testing in test/api_system_test.go. @shaloulcy

@shaloulcy shaloulcy force-pushed the pouch_info_volume_driver branch from 1dac414 to 13337d0 Compare May 18, 2018 10:08
feature: add volume drivers info for system info

Signed-off-by: Eric Li <lcy041536@gmail.com>
@shaloulcy shaloulcy force-pushed the pouch_info_volume_driver branch from 13337d0 to 480f054 Compare May 18, 2018 11:00
@pouchrobot pouchrobot added size/M and removed size/S labels May 18, 2018
@shaloulcy
Copy link
Contributor Author

@rudyfly @allencloud Fine! I have added ci test for this feature

@rudyfly
Copy link
Collaborator

rudyfly commented May 20, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 20, 2018
@rudyfly rudyfly merged commit 705dc49 into AliyunContainerService:master May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants