test: add cli test for pause command and fix some tiny bugs #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouchrobot
added
areas/cli
areas/test
kind/bug
Letty5411
reviewed
May 21, 2018
test/cli_pause_test.go
Outdated
| // pause with the container name missing and pause with an unwanted flag, respectively. | ||
| func (suite *PouchPauseSuite) TestPauseInWrongWay(c *check.C) { | ||
| // generate a stopped container to test | ||
| stoppedContainerName := "not running" |
There was a problem hiding this comment.
please change the container name to remove space.
Letty5411
reviewed
May 21, 2018
test/cli_pause_test.go
Outdated
| {name: "unwanted flag", args: "-m"}, | ||
| } { | ||
| res := command.PouchRun("pause", tc.args) | ||
| c.Assert(res.Error, check.IsNil, check.Commentf(tc.name)) |
There was a problem hiding this comment.
Need to check res.Stderr() including the expected error message.
Signed-off-by: Zou Rui <21751189@zju.edu.cn>
|
Updated @Letty5411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui 21751189@zju.edu.cn
Ⅰ. Describe what this PR did
This pr add the related cli test for
pausecommand and fix some tiny bugs to keep consistency with other commands.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews