bugfix: add judge for whether pidfile path is given #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1374 +/- ##
=======================================
Coverage 17.29% 17.29%
=======================================
Files 190 190
Lines 11913 11913
=======================================
Hits 2060 2060
Misses 9706 9706
Partials 147 147 |
|
@Ace-Tang please create PR base on branch |
Signed-off-by: Ace-Tang <aceapril@126.com>
HusterWan
reviewed
May 23, 2018
| defer func() { | ||
| if err := os.Remove(cfg.Pidfile); err != nil { | ||
| logrus.Errorf("failed to delete pidfile: %s", err) | ||
| if cfg.Pidfile != "" { |
There was a problem hiding this comment.
If Pidfile exists, do we need to truncate it's content ?
There was a problem hiding this comment.
Look at utils.NewPidfile, it won't go ahead when pidfile has value, it a common logic most process deal with.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
save pid into pidfile only when pidfile path is given, make code more reasonable.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews