-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add instruction for blkio-weight-device #1381
Conversation
blkio.weight_device need cfq io scheduler enable, add this instruction for blkio-weight-device add condition check for ci test TestRunBlockIOWeightDevice Same problem also exist in #1346. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
- Coverage 38.61% 38.53% -0.08%
==========================================
Files 248 248
Lines 16512 16512
==========================================
- Hits 6376 6363 -13
- Misses 9318 9328 +10
- Partials 818 821 +3
|
LGTM |
@@ -36,7 +36,7 @@ type Resources struct { | |||
// | |||
BlkioDeviceWriteIOps []*ThrottleDevice `json:"BlkioDeviceWriteIOps"` | |||
|
|||
// Block IO weight (relative weight). | |||
// Block IO weight (relative weight), need CFQ IO Scheduler enable. | |||
// Maximum: 1000 | |||
// Minimum: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
between 10 and 1000
Minimum should be 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Could you help fix this, @sunyuan3
cli: add instruction for blkio-weight-device Signed-off-by: Starnop <starnop@163.com>
blkio.weight_device need cfq io scheduler enable, add this
instruction for blkio-weight-device
add condition check for ci test TestRunBlockIOWeightDevice
Same problem also exist in #1346.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
Container fails to start, because sda's io scheduler is deadline, but blkio.weight_device need cfq,
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews