bugfix: make the PullImage test util work #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The post method of pullImage will hijack the connection so that the HTTP header always contains 200. It means that we cannot just check the HTTP status. We should read all the data bytes from server. Signed-off-by: Wei Fu <fhfuwei@163.com>
|
LGTM |
pouchrobot
added
the
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
- Coverage 38.61% 35.07% -3.54%
==========================================
Files 248 254 +6
Lines 16512 17795 +1283
==========================================
- Hits 6376 6242 -134
- Misses 9318 10737 +1419
+ Partials 818 816 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The post method of pullImage will hijack the connection so that the HTTP header always contains 200. It means that we cannot just check the HTTP status. We should read all the data bytes from server.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Read the bytes from server and check the error in the jsonstream.
Ⅳ. Describe how to verify it
Remove the
command.PouchRun("pull", busyboxImage)in the beginning of test so that we can make sure thePullImageworks well or not.Ⅴ. Special notes for reviews
It is very important to make CI happy