enhance: clean the local-persist after integration tests #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaloulcy
force-pushed
the
plugin_sock_clean
branch
from
2e0f818 to
6a1128e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
- Coverage 38.72% 34.87% -3.85%
==========================================
Files 250 254 +4
Lines 16630 18163 +1533
==========================================
- Hits 6440 6335 -105
- Misses 9362 11008 +1646
+ Partials 828 820 -8
|
shaloulcy
force-pushed
the
plugin_sock_clean
branch
3 times, most recently
from
d955b31 to
9c913c6
Compare
Letty5411
reviewed
May 24, 2018
hack/make.sh
Outdated
| function clean_local_persist | ||
| { | ||
| echo "Try cleaning local-persist" | ||
| pid=`ps axu|grep local-persist |grep -v grep|awk '{print $2}'` |
There was a problem hiding this comment.
How about just pgrep ? And use $() instead of ``
Letty5411
reviewed
May 24, 2018
hack/make.sh
Outdated
| echo "Try cleaning local-persist" | ||
| pid=`ps axu|grep local-persist |grep -v grep|awk '{print $2}'` | ||
|
|
||
| if [ -n "$pid" ]; then |
There was a problem hiding this comment.
use [[ ]] instead of [ ]
Signed-off-by: Eric Li <lcy041536@gmail.com>
shaloulcy
force-pushed
the
plugin_sock_clean
branch
from
9c913c6 to
de673c5
Compare
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Li lcy041536@gmail.com
Ⅰ. Describe what this PR did
After integration tests, we will clean the local-persist volume plugin
Ⅱ. Does this pull request fix one issue?
fix #1396
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews