Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sort image list before check #1413

Merged
merged 1 commit into from
May 25, 2018
Merged

test: sort image list before check #1413

merged 1 commit into from
May 25, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented May 24, 2018

Signed-off-by: Wei Fu fhfuwei@163.com

Ⅰ. Describe what this PR did

Since the image mgr return the images list in random order, in testing
we should sort before check and match.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

NONE

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels May 24, 2018
@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #1413 into master will increase coverage by 22.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1413       +/-   ##
==========================================
+ Coverage   16.23%   38.4%   +22.17%     
==========================================
  Files         200     248       +48     
  Lines       13583   16806     +3223     
==========================================
+ Hits         2205    6455     +4250     
+ Misses      11224    9527     -1697     
- Partials      154     824      +670
Impacted Files Coverage Δ
cli/main.go 0% <0%> (ø) ⬆️
daemon/logger/jsonfile/utils.go 70% <0%> (ø) ⬆️
client/image_tag.go
cli/tag.go
storage/volume/modules/ceph/types.go 0% <0%> (ø)
storage/volume/modules/ceph/map.go 0% <0%> (ø)
storage/quota/set_diskquota.go 9.09% <0%> (ø)
cri/stream/remotecommand/httpstream.go 0% <0%> (ø)
pkg/jsonstream/format.go 80.95% <0%> (ø)
storage/volume/driver/remote.go 75.4% <0%> (ø)
... and 115 more

@HusterWan
Copy link
Contributor

@fuweid If we modify test part code, we should add prefix test: before commit message

Since the image mgr return the images list in random order, in testing
we should sort before check and match.

Signed-off-by: Wei Fu <fhfuwei@163.com>
@fuweid
Copy link
Contributor Author

fuweid commented May 24, 2018

@HusterWan roger that.

@fuweid fuweid changed the title bugfix: sort image list before check test: sort image list before check May 24, 2018
@shaloulcy shaloulcy merged commit c8394a1 into AliyunContainerService:master May 25, 2018
@shaloulcy
Copy link
Contributor

LGTM

@fuweid fuweid deleted the bugfix_sort_image_id_before_check branch May 25, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants