refactor: remove ceph volume plugin #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaloulcy
force-pushed
the
remove_ceph_volume
branch
from
e82f91a to
ffcb893
Compare
shaloulcy
force-pushed
the
remove_ceph_volume
branch
from
ffcb893 to
0cee14c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
===========================================
+ Coverage 16.26% 39.99% +23.72%
===========================================
Files 206 249 +43
Lines 13759 16128 +2369
===========================================
+ Hits 2238 6450 +4212
+ Misses 11365 8865 -2500
- Partials 156 813 +657
|
allencloud
reviewed
May 31, 2018
| if driver == "" { | ||
| driver = types.DefaultBackend | ||
| } | ||
|
|
||
| id := types.VolumeID{ |
There was a problem hiding this comment.
I think the naming of VolumeID is so bad.
Is there anyway to change this to be a more readable one?
There was a problem hiding this comment.
@allencloud I will refactor VolumeID in other PRs later
rudyfly
reviewed
May 31, 2018
storage/volume/types/volume_util.go
Outdated
| @@ -105,6 +105,41 @@ func buildVolumeConfig(options map[string]string) (*VolumeConfig, error) { | |||
| return config, nil | |||
| } | |||
|
|
|||
| // NewVolumeFromVolumeID will create an Volume using mountPath, size and VolumeID. | |||
| func NewVolumeFromVolumeID(mountPath, size string, id VolumeID) *Volume { | |||
There was a problem hiding this comment.
Change to NewVolumeFromID ？
|
|
||
| return v | ||
| } | ||
|
|
||
| // NewVolume generates a volume based VolumeID | ||
| func NewVolume(id VolumeID) (*Volume, error) { |
There was a problem hiding this comment.
Change VolumeID to VolumeCreate？It means the parameter of create volume.
There was a problem hiding this comment.
plan to refactor VolumeID in other PRs
As the ceph volume plugin depends on alibaba storage service, ceph volume plugin can't work outside alibaba. So we will remove the ceph volume. If you need ceph storage, you can use contiv volume plugin (https://github.com/contiv-experimental/volplugin) Signed-off-by: Eric Li <lcy041536@gmail.com>
shaloulcy
force-pushed
the
remove_ceph_volume
branch
from
0cee14c to
b0b2928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the ceph volume plugin depends on alibaba storage service, ceph
volume plugin can't work outside alibaba. So we will remove the ceph
volume. If you need ceph storage, you can use contiv volume plugin
(https://github.com/contiv-experimental/volplugin)
Signed-off-by: Eric Li lcy041536@gmail.com
Ⅰ. Describe what this PR did
As the ceph volume plugin depends on alibaba storage service, ceph volume plugin can't work outside alibaba. So we will remove the ceph volume. If you need ceph storage, you can use contiv volume plugin(https://github.com/contiv-experimental/volplugin)
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Remove ceph volume driver
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews