bugfix: add attach volume when container start #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1483 +/- ##
==========================================
+ Coverage 41.25% 41.32% +0.06%
==========================================
Files 255 255
Lines 16837 16874 +37
==========================================
+ Hits 6946 6973 +27
- Misses 9024 9031 +7
- Partials 867 870 +3
|
shaloulcy
reviewed
Jun 10, 2018
| @@ -26,6 +26,9 @@ type Driver interface { | |||
| type Opt interface { | |||
| // Options return module customize volume options. | |||
| Options() map[string]types.Option | |||
|
|
|||
| // Config is used to pass the daemon volume configure into driver. | |||
| Config(Context, map[string]interface{}) error | |||
There was a problem hiding this comment.
I think the Driver interface should implement Config method, not the Opt interface. WDYT? @rudyfly
There was a problem hiding this comment.
I have refacted it, PTAL 😄
yyb196
reviewed
Jun 13, 2018
daemon/mgr/container.go
Outdated
| continue | ||
| } | ||
|
|
||
| attachedVolumes := map[string]struct{}{} |
There was a problem hiding this comment.
is it necessary to add a defer in a loop
There was a problem hiding this comment.
oh, it should defer outside the loop
rudyfly
force-pushed
the
volume
branch
2 times, most recently
from
85a41b9 to
05c8472
Compare
Add attach volume when container start. Now volume attaching is at container create stage, but if host have been restarted, container won't be created, so volume can't be attached. Add Config() for volume driver, it makes volume driver can use the configure of volume in daemon. Now set `volume-meta-dir` and `volume-timeout` into driver config. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add attach volume when container start. Now volume attaching is
at container create stage, but if host have been restarted, container won't be
created, so volume can't be attached.
Add Config() for volume driver, it makes volume driver can use the
configure of volume in daemon. Now set
volume-meta-dirandvolume-timeoutinto driver config.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
A running container can start again after host have been restarted.
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com