Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support nullable bool value set in config #1502

Merged
merged 1 commit into from
Jun 11, 2018
Merged

fix: support nullable bool value set in config #1502

merged 1 commit into from
Jun 11, 2018

Conversation

Ace-Tang
Copy link
Contributor

make nullable value like false and 0 not be recognized as
empry value, in config set, they should be valid value.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

make nullable value like `false` and 0 not be recognized as
empry value, in config set, they should be valid value.

Signed-off-by: Ace-Tang <aceapril@126.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Jun 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #1502 into master will decrease coverage by 0.91%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   40.56%   39.64%   -0.92%     
==========================================
  Files         254      254              
  Lines       16537    16891     +354     
==========================================
- Hits         6708     6697      -11     
- Misses       8966     9329     +363     
- Partials      863      865       +2
Impacted Files Coverage Δ
pkg/utils/utils.go 85.27% <0%> (-0.36%) ⬇️
daemon/mgr/spec_mount.go 54.54% <0%> (-15.67%) ⬇️
apis/server/utils.go 59.52% <0%> (-4.77%) ⬇️
ctrd/watch.go 75% <0%> (-3.13%) ⬇️
daemon/mgr/network.go 68.94% <0%> (-0.49%) ⬇️
daemon/mgr/container.go 49.2% <0%> (-0.09%) ⬇️
cri/v1alpha2/cri.go 0% <0%> (ø) ⬆️
cri/v1alpha1/cri.go 0% <0%> (ø) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented Jun 11, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 11, 2018
@allencloud allencloud merged commit a0ef39d into AliyunContainerService:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants