bugfix: rm omitempty in resource fields #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
rm-omitempty-in-resources
branch
4 times, most recently
from
5fc2632 to
8f254e7
Compare
|
It will be better to find a way to generate no |
|
And please make CI passed, @allencloud . |
allencloud
commented
Jun 12, 2018
| @@ -270,10 +270,6 @@ func (s *Server) updateContainer(ctx context.Context, rw http.ResponseWriter, re | |||
| if err := json.NewDecoder(req.Body).Decode(config); err != nil { | |||
| return httputils.NewHTTPError(err, http.StatusBadRequest) | |||
| } | |||
| // validate request body | |||
| if err := config.Validate(strfmt.NewFormats()); err != nil { | |||
There was a problem hiding this comment.
I removed the request body validation in update, then I think it will pass the CI. @Ace-Tang @HusterWan
Codecov Report
@@ Coverage Diff @@
## master #1505 +/- ##
==========================================
- Coverage 41.59% 41.58% -0.02%
==========================================
Files 267 267
Lines 17366 17364 -2
==========================================
- Hits 7223 7220 -3
- Misses 9251 9253 +2
+ Partials 892 891 -1
|
|
@allencloud @Ace-Tang You can see: go-swagger/go-swagger#1189, we use swagger version is 0.12.0, and I cherry-pick this pr to 0.12.0 version, and it use |
|
ping @allencloud |
|
Hi @allencloud , Please resolve conflicts, and lgtm |
pouchrobot
added
LGTM
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
rm-omitempty-in-resources
branch
from
57c1da6 to
2b8a144
Compare
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
rm-omitempty-in-resources
branch
from
2b8a144 to
f3e9cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
In #1491, @Ace-Tang mentioned that we should not omit zero-value fields in api data transfer.
This pull request removes
omitemptyfor fields inResources.But this seems not supported in swagger
Ⅱ. Does this pull request fix one issue?
fix #1491
Ⅲ. Describe how you did it
Add required parameters in swagger.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews