bugfix: restore config after update fail #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if pouch update a container get error, restore container config, aviod container record error config. Fixes: #1512 Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
- Coverage 40.56% 40.48% -0.09%
==========================================
Files 254 254
Lines 16535 16547 +12
==========================================
- Hits 6708 6699 -9
- Misses 8965 8980 +15
- Partials 862 868 +6
|
allencloud
added
the
priority/P1
|
I think this issue is quite severe, and we need to fix this ASAP. |
|
since this problem is severe, i will first merge it. LGTM |
pouchrobot
added
the
LGTM
allencloud
reviewed
Jun 12, 2018
| @@ -752,6 +752,18 @@ func (mgr *ContainerManager) Update(ctx context.Context, name string, config *ty | |||
| return err | |||
| } | |||
|
|
|||
| restore := false | |||
There was a problem hiding this comment.
I am wondering if we need the new variable restore. Could we just decide whether to rollback via the nullable of err? @Ace-Tang @HusterWan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if pouch update a container get error, restore container
config, aviod container record error config.
Fixes: #1512
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Fixes: #1512
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews