bugfix: skip teardown network, if the sandbox has been stopped #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1539 +/- ##
==========================================
- Coverage 41.25% 38.36% -2.89%
==========================================
Files 255 257 +2
Lines 16837 17691 +854
==========================================
- Hits 6946 6788 -158
- Misses 9024 10038 +1014
+ Partials 867 865 -2
|
|
@allencloud PTAL |
fuweid
reviewed
Jun 19, 2018
cri/v1alpha1/cri.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } else if !os.IsNotExist(err) { | ||
| return nil, err |
There was a problem hiding this comment.
In order to add more information in the error, could we use pkgerrors.Wrap to wrap the error? WDYT?
cri/v1alpha1/cri.go
Outdated
| return nil, err | ||
| } | ||
| // If the sandbox has been closed, the corresponding network namespace |
There was a problem hiding this comment.
Could we put the comment on the top?
cri/v1alpha2/cri.go
Outdated
| return nil, err | ||
| } | ||
| // If the sandbox has been closed, the corresponding network namespace |
There was a problem hiding this comment.
Could we put the comment on the top of if? if not, it seems that we delete the code but not comment. 😄
cri/v1alpha2/cri.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } else if !os.IsNotExist(err) { | ||
| return nil, err |
There was a problem hiding this comment.
use pkgerrors.Wrap to show the error which means that the file has been removed. WDYT?
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
|
@fuweid Updated. |
|
LGTM |
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
Please refer: #1536
When stop the sandbox, if the network namespace file of the sandbox does not exist, skip tearing down the pod network.
Ⅱ. Does this pull request fix one issue?
fixes #1536
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews