bugfix: change the order of generating MountPoints

[shaloulcy]

Signed-off-by: Eric Li lcy041536@gmail.com

Ⅰ. Describe what this PR did

change the order of generating mountpoints.

1. generate MountPoints from other containers(volumes-from)
2. generate MountPoints from binds
3. generate MountPoints from images
4. generate MountPoints from Config.Volumes

Why?

Every volume has a destination in container. So if two volume have the same destination, only one volume takes effect.

Now the order of volume taking effect is

1. generate MountPoints from Config.Volumes
2. generate MountPoints from images
3. generate MountPoints from binds
4. generate MountPoints from other containers(volume-from)

So if Config.Volumes, images, binds and volume-from all have a volume whose destination is the same. Only the Config.Volumes will take effect.

Indeed, the right order is

volumes-from 》 binds 》images 》Config.Volumes

I will add some test-cases in other Prs

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

change the order of generating MountPoints

volumes-from 》 binds 》images 》Config.Volumes

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[codecov-io]

Codecov Report

Merging #1541 into master will increase coverage by 23.67%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #1541       +/-   ##
==========================================
+ Coverage   16.83%   40.5%   +23.67%     
==========================================
  Files         211     254       +43     
  Lines       14062   16750     +2688     
==========================================
+ Hits         2367    6785     +4418     
+ Misses      11533    9099     -2434     
- Partials      162     866      +704

Impacted Files	Coverage Δ
daemon/mgr/container.go	49.21% <50%> (+49.21%)	⬆️
cri/v1alpha1/cri.go	0% <0%> (ø)	⬆️
cri/v1alpha2/cri.go	0% <0%> (ø)	⬆️
apis/metrics/metrics.go	100% <0%> (ø)
storage/volume/error/errors.go	28.57% <0%> (ø)
cri/stream/errors.go	0% <0%> (ø)
cri/stream/remotecommand/httpstream.go	0% <0%> (ø)
cri/v1alpha2/service/cri.go	0% <0%> (ø)
storage/quota/set_diskquota.go	9.09% <0%> (ø)
cri/stream/remotecommand/attach.go	0% <0%> (ø)
... and 116 more

[allencloud]

Could you tell us more about the reason why you change the sequence? @shaloulcy

[rudyfly]

LGTM

[shaloulcy]

@allencloud I have explain the reason in PR Description