feature: adjust pouchd unix socket premissions #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
reviewed
Jun 21, 2018
apis/server/server.go
Outdated
| if err := syscall.Unlink(path); err != nil && !os.IsNotExist(err) { | ||
| return nil, err | ||
| } | ||
| mask := syscall.Umask(0777) |
There was a problem hiding this comment.
Could we use oldMask to make it clear?
There was a problem hiding this comment.
Why it need to named oldMask?
There was a problem hiding this comment.
apis/server/server.go
Outdated
| if err != nil { | ||
| // ignore error when group pouch not exist, group pouch should to be | ||
| // created before pouchd started, it means code not create pouch group | ||
| logrus.Warnf("failed to found group pouch") |
adjust pouchd unix socket file mode, make it ownered by group pouch. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
===========================================
+ Coverage 17.89% 41.61% +23.72%
===========================================
Files 223 267 +44
Lines 14711 17362 +2651
===========================================
+ Hits 2633 7226 +4593
+ Misses 11906 9246 -2660
- Partials 172 890 +718
|
|
LGTM Next action: separate |
|
Oh, do you want to help this, @fuweid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust pouchd unix socket file mode, make it ownered by group
pouch.
Ⅰ. Describe what this PR did
Before this patch, we can only use pouch with user root, with this patch, we add this permission to group pouch. We create a unix sock with pouch group, and change it mode to 0660, make other group can write
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews