enhance: add new formatter for syslog #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 41.99% 41.99% -0.01%
==========================================
Files 270 270
Lines 17597 17607 +10
==========================================
+ Hits 7390 7394 +4
- Misses 9298 9304 +6
Partials 909 909
|
shaloulcy
reviewed
Jul 2, 2018
daemon/logger/syslog/fmt.go
Outdated
| @@ -17,9 +17,9 @@ func rfc5424FormatterWithTagAsAppName(p srslog.Priority, hostname, tag, content | |||
| } | |||
|
|
|||
| func rfc5424MicroFormatterWithTagAsAppName(p srslog.Priority, hostname, tag, content string) string { | |||
There was a problem hiding this comment.
does rfc5424FormatterWithTagAsAppName need to change?
There was a problem hiding this comment.
This is WIP for check. I will close it.
|
Reuse this branch @shaloulcy sorry for that |
fuweid
changed the title
|
Update the code and comment. Please take a look @shaloulcy |
|
ping @fuweid |
A lot of log collectors consumes log data and indexs it by the timestamp in millisecond format. In order to make the collector to consume data in the order, we need to add the sequence number in the log. Simplify the case, PouchContainer will uses the nano timestamp as sequene number. Signed-off-by: Wei Fu <fhfuwei@163.com>
|
LGTM |
pouchrobot
added
the
LGTM
|
@fuweid please rebase your code~ |
|
I have rebased my code with latest upstream... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
A lot of log collectors consumes log data and indexs it by the timestamp in millisecond format. In order to make the collector to consume data in the order, we need to add the sequence number in the log. Simplify the case, PouchContainer will uses the nano timestamp as sequene number.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Add one more syslog formatter
Ⅳ. Describe how to verify it
First, we should follow the
/var/log/syslogand runpouch run --log-driver syslog --log-opt syslog-format=rfc5424micro-seq --log-opt tag={{.DaemonName}} busybox echo hi.We will got the message in the syslog like:
Ⅴ. Special notes for reviews