Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for function ValidateOOMScore in oom_score_test.go #1658

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

quyi1993
Copy link
Contributor

@quyi1993 quyi1993 commented Jul 9, 2018

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1639

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @quyi1993
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

@quyi1993 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1658 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   41.16%   41.03%   -0.13%     
==========================================
  Files         274      274              
  Lines       18091    18091              
==========================================
- Hits         7447     7424      -23     
- Misses       9729     9758      +29     
+ Partials      915      909       -6
Impacted Files Coverage Δ
pkg/meta/store.go 54.76% <0%> (-4.77%) ⬇️
daemon/containerio/cio.go 58.73% <0%> (-4.77%) ⬇️
daemon/containerio/container_io.go 53.59% <0%> (-4.42%) ⬇️
daemon/mgr/system.go 73.27% <0%> (-3.45%) ⬇️
ctrd/image.go 75.27% <0%> (-2.75%) ⬇️
daemon/mgr/container_utils.go 54.97% <0%> (-1.74%) ⬇️
daemon/mgr/container.go 50.23% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️
apis/opts/oom_score.go 100% <0%> (+100%) ⬆️

@faremax
Copy link

faremax commented Jul 10, 2018

issue #1639

@allencloud allencloud changed the title oom_score_test.go test: add unit test for function ValidateOOMScore in oom_score_test.go Jul 13, 2018
@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit 6756ca7 into AliyunContainerService:master Jul 13, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for ValidateOOMScore
6 participants