Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: TestRemoveVolume #1679

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Conversation

mengjiahao
Copy link
Contributor

Ⅰ. Describe what this PR did

#1633 add unit-test for RemoveVolume

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

NONE

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

NONE

@pouchrobot
Copy link
Collaborator

@mengjiahao Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @mengjiahao
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1679 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   41.16%   41.15%   -0.01%     
==========================================
  Files         274      274              
  Lines       18091    18091              
==========================================
- Hits         7447     7446       -1     
- Misses       9729     9732       +3     
+ Partials      915      913       -2
Impacted Files Coverage Δ
ctrd/image.go 75.27% <0%> (-2.75%) ⬇️
daemon/mgr/system.go 75% <0%> (-1.73%) ⬇️
storage/volume/core.go 58.53% <0%> (+1.95%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️

@allencloud allencloud changed the title test: TestRemoveVolume[C test: TestRemoveVolume Jul 10, 2018
@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit eba0b62 into AliyunContainerService:master Jul 13, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants