Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-test for ValidateCPUPeriod #1690

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

johanzhu
Copy link

@johanzhu johanzhu commented Jul 10, 2018

Ⅰ. Issue Description

Add unit-test for ValidateCPUPeriod method which locate on apis/opts/cpu.go.
fixes #1637

Ⅱ. Describe what happened

Add unit-test for ValidateCPUPeriod method which locate on apis/opts/cpu.go

Ⅲ. Describe what you expected to happen

All test case passed.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Baiji 262 group 2.

Ⅵ. Environment:
pouch version (use pouch version):go1.10.3 darwin/amd64
OS (e.g. from /etc/os-release): CentOS linux 7
Kernel (e.g. uname -a):3.10.0
Install tools: visualbox git go
Others:none

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @johanzhu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

@johanzhu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1690 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
+ Coverage   41.16%   41.19%   +0.02%     
==========================================
  Files         274      274              
  Lines       18091    18091              
==========================================
+ Hits         7447     7452       +5     
+ Misses       9729     9726       -3     
+ Partials      915      913       -2
Impacted Files Coverage Δ
ctrd/image.go 75.27% <0%> (-2.75%) ⬇️
daemon/mgr/system.go 75% <0%> (-1.73%) ⬇️
daemon/mgr/container.go 50.23% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️
apis/opts/cpu.go 50% <0%> (+50%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 13, 2018
@allencloud allencloud merged commit 98913ec into AliyunContainerService:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for ValidateCPUPeriod
4 participants