-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make all quota implementation logic clear #1736
Merged
rudyfly
merged 1 commit into
AliyunContainerService:master
from
allencloud:refactor-quota
Aug 3, 2018
Merged
refactor: make all quota implementation logic clear #1736
rudyfly
merged 1 commit into
AliyunContainerService:master
from
allencloud:refactor-quota
Aug 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
refactor-quota
branch
from
July 13, 2018 08:51
6210a15
to
da0c03f
Compare
allencloud
force-pushed
the
refactor-quota
branch
2 times, most recently
from
July 13, 2018 08:58
620e2eb
to
eccb3bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1736 +/- ##
==========================================
+ Coverage 63.55% 63.69% +0.14%
==========================================
Files 200 201 +1
Lines 15527 15492 -35
==========================================
Hits 9868 9868
+ Misses 4424 4388 -36
- Partials 1235 1236 +1
|
allencloud
force-pushed
the
refactor-quota
branch
from
July 16, 2018 06:42
eccb3bb
to
220a493
Compare
ping @allencloud CI fails according integration system. If this is flaky test, welcome to track this with profiling an issue. build url: https://travis-ci.org/alibaba/pouch/builds/404317084 |
allencloud
force-pushed
the
refactor-quota
branch
from
July 27, 2018 07:34
220a493
to
55b50ef
Compare
allencloud
force-pushed
the
refactor-quota
branch
4 times, most recently
from
July 27, 2018 10:09
d60d9b3
to
fd0b42e
Compare
allencloud
force-pushed
the
refactor-quota
branch
from
August 1, 2018 07:07
fd0b42e
to
dcd13dd
Compare
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
refactor-quota
branch
from
August 1, 2018 07:44
dcd13dd
to
b3f5531
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
Once the disk quota implementation code is not well-mantained. This could be the potential risk in the project. Here we need to try to make the interface, variable, code block much more clear and readable.
Then in this PR, I try to refactor to polish the disk quota implement:
loadQuotaIDs
.Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none