refactor: reorder hack scripts #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
===========================================
+ Coverage 14.16% 56.14% +41.98%
===========================================
Files 281 200 -81
Lines 56797 15657 -41140
===========================================
+ Hits 8043 8790 +747
+ Misses 47817 5769 -42048
- Partials 937 1098 +161
|
* refactor hack/build, hack/make.sh and Makefile * refactor .travis.yml to split testing into three jobs * use gometalinter to do all the linters Signed-off-by: Wei Fu <fhfuwei@163.com>
|
LGTM |
pouchrobot
added
the
LGTM
|
The change is very large. @YaoZengzeng , @Letty5411 and @chuanchang please take a look again. Thanks |
Letty5411
reviewed
Jul 20, 2018
|
|
||
| cd "$(dirname "${BASH_SOURCE[0]}")" | ||
| source utils.sh | ||
|
|
There was a problem hiding this comment.
I would prefer to use absolute dir instead of cd to source the utils.sh
|
Another question is do we need to modify related docs in pouch/doc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Reorder hack scripts and make the code coverage correct.
Ⅱ. Does this pull request fix one issue?
fixes #1582
Ⅲ. Describe how you did it
hack/installdir to contains all about the dependencies install thinghack/testingdir to contains all about the integration thing.However, I still maintain the
hack/buildandhack/make.shsince both thedepandrpmpackages need them. In the following the PR, we should remove the legacy code and refactor the package-scripts.Besides this, I also refactor
travis.ymlto splits the testing into three jobs.Based on this, we can use the tag for the job coverage so that
Codecovcan combine three kinds of coverages into one. Please check the comment created byCodecov, like:33.52% <ø> (?)37.67% <ø> (?)20.33% <ø> (?)Ⅳ. Describe how to verify it
Eye ball?
Ⅴ. Special notes for reviews