bugfix: pouch pull should handle space input as an error #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I didn't notice that you did it. I will close my PR，could you add a test ? |
oiooj
reviewed
Jul 19, 2018
pkg/reference/parse.go
Outdated
| // defaultTag is latest if there is no tag | ||
| defaultTag = "latest" | ||
| ) | ||
|
|
||
| // Parse parses ref into reference.Named. | ||
| func Parse(ref string) (Named, error) { | ||
| if ok := regRef.MatchString(ref); !ok { | ||
| return nil, ErrInvalid | ||
| return nil, errors.New("invalid reference: " + ref) |
There was a problem hiding this comment.
The input from users, so we don't need to do this maybe, and this change also breaks the test.
There was a problem hiding this comment.
Thanks for your kindly reminding~
Signed-off-by: xiechengsheng <XIE1995@whut.edu.cn>
xiechengsheng
force-pushed
the
fix-bug-1748
branch
from
450fc55
to
daa50cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
- Coverage 14.16% 14.16% -0.01%
==========================================
Files 281 281
Lines 56797 56799 +2
==========================================
Hits 8043 8043
- Misses 47817 47818 +1
- Partials 937 938 +1
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiechengsheng XIE1995@whut.edu.cn
Ⅰ. Describe what this PR did
pouch pull should handle space input as an error
Ⅱ. Does this pull request fix one issue?
Fixes #1748
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews