Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit-test for Volume Core's VolumePath method #1788

Merged
merged 1 commit into from
Jul 24, 2018
Merged

add unit-test for Volume Core's VolumePath method #1788

merged 1 commit into from
Jul 24, 2018

Conversation

gfl699468
Copy link
Contributor

Ⅰ. Describe what this PR did

add unit-test for Volume Core's VolumePath method

Ⅱ. Does this pull request fix one issue?

fix #1762

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

run
go test ./storage/volume/core_test.go ./storage/volume/core.go ./storage/volume/core_util.go ./storage/volume/config.go

Ⅴ. Special notes for reviews

baiji group 1

@pouchrobot
Copy link
Collaborator

@gfl699468 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @gfl699468
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1788 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1788     +/-   ##
========================================
+ Coverage    56.3%   56.4%   +0.1%     
========================================
  Files         200     200             
  Lines       15657   15657             
========================================
+ Hits         8816    8832     +16     
+ Misses       5745    5733     -12     
+ Partials     1096    1092      -4
Flag Coverage Δ
#critest 33.46% <ø> (-0.02%) ⬇️
#integrationtest 37.71% <ø> (+0.05%) ⬆️
#unittest 20.4% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 53.3% <0%> (+0.15%) ⬆️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
storage/volume/core.go 60.48% <0%> (+0.97%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
ctrd/image.go 81.18% <0%> (+4.45%) ⬆️

@sunyuan3 sunyuan3 merged commit de61fc7 into AliyunContainerService:master Jul 24, 2018
@sunyuan3
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for VolumePath
5 participants