Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: simplify makefile output #1921

Merged
merged 1 commit into from
Jul 30, 2018
Merged

makefile: simplify makefile output #1921

merged 1 commit into from
Jul 30, 2018

Conversation

Ace-Tang
Copy link
Contributor

remove golang build command in make progress.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

remove golang build command in make progress.

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov-io
Copy link

Codecov Report

Merging #1921 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1921      +/-   ##
==========================================
- Coverage   62.64%   62.61%   -0.04%     
==========================================
  Files         200      200              
  Lines       15567    15567              
==========================================
- Hits         9752     9747       -5     
- Misses       4567     4570       +3     
- Partials     1248     1250       +2
Flag Coverage Δ
#criv1alpha1test 33.21% <ø> (-0.05%) ⬇️
#criv1alpha2test 33.71% <ø> (-0.03%) ⬇️
#integrationtest 37.95% <ø> (-0.02%) ⬇️
#unittest 20.48% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha1/cri.go 65.04% <0%> (-0.19%) ⬇️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 12a4930 into AliyunContainerService:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants