-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add request handling statistics for pouch daemon #2037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
+ Coverage 23.47% 62.08% +38.6%
==========================================
Files 180 200 +20
Lines 15860 15547 -313
==========================================
+ Hits 3723 9652 +5929
+ Misses 11860 4677 -7183
- Partials 277 1218 +941
|
allencloud
force-pushed
the
add-req-stats
branch
2 times, most recently
from
August 10, 2018 09:08
48ac27d
to
1ee251a
Compare
allencloud
force-pushed
the
add-req-stats
branch
from
August 11, 2018 02:44
1ee251a
to
06f4bd0
Compare
I think we need to review the API very carefully. @HusterWan @fuweid |
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
add-req-stats
branch
from
October 8, 2018 04:08
06f4bd0
to
eb4b4c8
Compare
ping @allencloud |
will reopen it if we need it. cc @allencloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
When called by upper systems, pouch daemon bears lots of requests there. Then what is the dealing status of all these request is a quite important dimension for evaluate whether the daemon deals them very well.
For the API layers, we plan to provide a brand new API endpoint:
GET /stats
It returns
ResponseStats
:If the pouchd restarts, then all the data will start from 0.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews