bugfix: fix stdin hang when kubectl exec
#2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
reviewed
Aug 2, 2018
| @@ -53,6 +53,7 @@ func (s *streamRuntime) Exec(ctx context.Context, containerID string, cmd []stri | |||
| } | |||
|
|
|||
| attachConfig := &mgr.AttachConfig{ | |||
| Stdin: streamOpts.Stdin, | |||
There was a problem hiding this comment.
can we add test case to lock this error?
There was a problem hiding this comment.
Maybe we should make an issue for cri-tools to make the test more complete.
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
|
LGTM |
pouchrobot
added
the
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
=========================================
Coverage ? 63.84%
=========================================
Files ? 201
Lines ? 15528
Branches ? 0
=========================================
Hits ? 9914
Misses ? 4381
Partials ? 1233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews