Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases about modifyHostConfig #2056

Merged

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Aug 6, 2018

Signed-off-by: Starnop starnop@163.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@starnop starnop force-pushed the cri-test-modifyHostConfig branch 2 times, most recently from f0ae562 to 4da0212 Compare August 6, 2018 11:04
@codecov-io
Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #2056 into master will increase coverage by 5.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   58.89%   64.03%   +5.14%     
==========================================
  Files         202      202              
  Lines       15535    15535              
==========================================
+ Hits         9149     9948     +799     
+ Misses       5283     4352     -931     
- Partials     1103     1235     +132
Flag Coverage Δ
#criv1alpha1test 33.73% <ø> (?)
#criv1alpha2test 34.26% <ø> (+0.07%) ⬆️
#integrationtest 38.45% <ø> (-0.02%) ⬇️
#unittest 23.16% <ø> (+0.46%) ⬆️
Impacted Files Coverage Δ
daemon/mgr/system.go 76.92% <0%> (-1.71%) ⬇️
daemon/mgr/container.go 53.89% <0%> (+0.15%) ⬆️
cri/v1alpha2/cri.go 66.2% <0%> (+0.17%) ⬆️
cri/v1alpha2/cri_utils.go 82.12% <0%> (+0.63%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
ctrd/watch.go 75.75% <0%> (+3.03%) ⬆️
cri/criservice.go 64.7% <0%> (+24.99%) ⬆️
cri/v1alpha1/cri_utils.go 83.45% <0%> (+27.4%) ⬆️
cri/v1alpha1/cri_wrapper.go 55.8% <0%> (+55.8%) ⬆️
cri/v1alpha1/cri.go 65.36% <0%> (+65.36%) ⬆️
... and 4 more

Signed-off-by: Starnop <starnop@163.com>
@YaoZengzeng
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants