refactor: move functions from pre-start hook to pouchd #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
- Coverage 63.86% 63.84% -0.02%
==========================================
Files 205 206 +1
Lines 15759 15762 +3
==========================================
- Hits 10064 10063 -1
- Misses 4441 4444 +3
- Partials 1254 1255 +1
|
HusterWan
reviewed
Aug 7, 2018
daemon/mgr/container.go
Outdated
| @@ -2224,6 +2236,104 @@ func (mgr *ContainerManager) populateVolumes(ctx context.Context, c *Container) | |||
| return nil | |||
| } | |||
|
|
|||
| func (mgr *ContainerManager) setMountTab(ctx context.Context, c *Container) error { | |||
There was a problem hiding this comment.
mgr/container.go are too big, some functions are worked for container object, maybe we can put the code into container_type.go, WDYT???
There was a problem hiding this comment.
I add a new file container_storage.go to manager the operation of container storage module.
move the functions: `set rootfs quota` and `set mtab` from pre-start hook in runc to pouchd container's create. Pouchd mounts the rootfs and do these functions, if it is successful, and then umount the rootfs. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
@rudyfly , get the ci passed, then LGTM, except a question: would mount in pouchd meet the |
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
move the functions:
set rootfs quotaandset mtabfrom pre-starthook in runc to pouchd container's create. Pouchd mounts the rootfs and
do these functions, if it is successful, and then umount the rootfs.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com